From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 0/2] IOPL related fixes
Date: Sun, 25 Nov 2018 11:42:02 +0100
Message-ID: <5128156.OEWx9KzbiF@xps>
References: <20181123143620.10480-1-i.maximets@samsung.com>
 <2f95ce88-8f61-10c0-9131-49e2a5d10048@redhat.com> <2699010.cjLPUA7OeM@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,
 David Marchand <david.marchand@redhat.com>, Tiwei Bie <tiwei.bie@intel.com>,
 Zhihong Wang <zhihong.wang@intel.com>, Ferruh Yigit <ferruh.yigit@intel.com>,
 Ian Stokes <ian.stokes@intel.com>,
 Bruce Richardson <bruce.richardson@intel.com>
To: Ilya Maximets <i.maximets@samsung.com>, Kevin Traynor <ktraynor@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id E9B991B611
 for <dev@dpdk.org>; Sun, 25 Nov 2018 11:42:05 +0100 (CET)
In-Reply-To: <2699010.cjLPUA7OeM@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

23/11/2018 23:29, Thomas Monjalon:
> 23/11/2018 21:07, Kevin Traynor:
> > On 11/23/2018 04:25 PM, Maxime Coquelin wrote:
> > > On 11/23/18 4:53 PM, Ilya Maximets wrote:
> > >> On 23.11.2018 18:41, Maxime Coquelin wrote:
> > >>> On 11/23/18 4:39 PM, Ilya Maximets wrote:
> > >>>> Patches primary targeted to fix OVS unit test failures with
> > >>>> DPDK 18.11 due to following error:
> > >>>>       'IOPL call failed - cannot use virtio PMD'.
> > >>>
> > >>> You mention v18.11, do you mean this is a regression?
> > >>
> > >> Kind of. But not really a bug. It's just a message that shows up
> > >> every time you starting the app as a non-root user.
> > >>
> > >> The message itself was introduced long time ago, but it wasn't
> > >> printed for unclear reasons. It's probably some change in logging
> > >> subsystem uncovered it.
> > >>
> > >> I just checked and found that message appears starting from v18.02.
> > >> But OVS stuck with 17.11 LTS where this message exists, but not
> > >> printed for some reason. That's why this wasn't an issue previously.
> > > 
> > > Thanks for the clarification.
> > > In that case, we may want it in v18.11 LTS, but I think it can wait or
> > > v18.11.1.
> > 
> > It would be better if it can be in 18.11. Upstream OVS will point at a
> > release tarball, and at present an 18.11.1 release is not due until
> > mid-January. If it's too late for 18.11, alternatively we could do an
> > earlier 18.11.1 release.
> 
> I won't take any risk at this stage.
> The memory of the headaches we had in the past with iopl is too much strong.
> The real change of this patch is to register the PMD even without successful iopl.
> I would like to be sure it won't cause any regression.

After more thinking, I decide to take the risk.
Take it as a gift to OVS :-)

Series applied