From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Subject: Re: [PATCH v2 5/7] net/virtio_user: add vhost kernel
 support
Date: Thu, 12 Jan 2017 17:40:10 +0800
Message-ID: <5129c726-30fa-d4ed-a0c0-5b811772a6fb@intel.com>
References: <1480689075-66977-1-git-send-email-jianfeng.tan@intel.com>
 <1482477266-39199-1-git-send-email-jianfeng.tan@intel.com>
 <1482477266-39199-6-git-send-email-jianfeng.tan@intel.com>
 <46af618f-c01b-3571-78fc-12d10859a4a1@redhat.com>
 <4fa4d06c-d359-df12-a073-7c2c2540b634@intel.com>
 <fd33abf3-3daf-4963-5ab3-018ebe6c4a67@redhat.com>
 <b82e84e0-7412-6928-529e-51072491af4a@intel.com>
 <83c1bc3a-7b16-6f73-f0ba-6ed5c863eaa5@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: yuanhan.liu@linux.intel.com, ferruh.yigit@intel.com,
 cunming.liang@intel.com
To: Jason Wang <jasowang@redhat.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 0E123F616
 for <dev@dpdk.org>; Thu, 12 Jan 2017 10:40:12 +0100 (CET)
In-Reply-To: <83c1bc3a-7b16-6f73-f0ba-6ed5c863eaa5@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Jason,

> Ok, just want to show its advantages. It can be added on top.
>
> And two more suggestions:
> - better to split tap support out of vhost file

Good suggestion! Will do that in next version.

> - kernel support more than 8 queues on recent kernel, so there's no 
> need to limit it to 8. When running on old kernel, TUNSETIFF will fail 
> which can give user a hint to reduce #queues.
>

After a try, even we remove such restriction in vhost_kernel backend, we 
are still restricted by VIRTIO_MAX_VIRTQUEUES (8) defined in virtio PMD.

Thanks for the suggestions!

Jianfeng