From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 1/2] testpmd: add forwarding mode to
	simulate a noisy neighbour
Date: Fri, 29 Jun 2018 16:28:49 +0200
Message-ID: <5136032.mYA4okFhoJ@xps>
References: <20180623080840.315-1-maxime.coquelin@redhat.com>
 <195bb20b-441a-571e-8925-6db0a8af56c2@redhat.com>
 <8CEF83825BEC744B83065625E567D7C260CBAC13@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "ailan@redhat.com" <ailan@redhat.com>,
 "jan.scheurich@ericsson.com" <jan.scheurich@ericsson.com>,
 "vkaplans@redhat.com" <vkaplans@redhat.com>, "Richardson,
 Bruce" <bruce.richardson@intel.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>, "Yigit,
 Ferruh" <ferruh.yigit@intel.com>, Jens Freimann <jfreimann@redhat.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 85D9B1B4C9
 for <dev@dpdk.org>; Fri, 29 Jun 2018 16:28:53 +0200 (CEST)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CBAC13@IRSMSX108.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

29/06/2018 16:05, Iremonger, Bernard:
> Hi Maxime, Thomas,
> 
> <snip>
> > Subject: Re: [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy
> > neighbour
> > 
> > Hi Bernard,
> > 
> > On 06/26/2018 01:09 PM, Iremonger, Bernard wrote:
> > > checkpatch.pl  is showing the following warnings:
> > >
> > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> > > #122: FILE: app/test-pmd/noisy_vnf.c:1:
> > > +/* SPDX-License-Identifier: BSD-3-Clause
> > 
> > I'm not sure to get what is wrong here, any thoughts?
> > 
> 
> I have looked at code and compared it with other license headers and it looks ok to me.
> 
> Hi Thomas,
> 
> Could you take a look please to see if you can spot something.

You should use devtools/checkpatches.sh, it is configured to ignore SPDX warnings
among other things.