From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [RFC 8/9] net/avf: enable ops to check queue info
 and status
Date: Tue, 21 Nov 2017 16:09:08 -0800
Message-ID: <5141b2ac-be19-8b69-ff66-2bdcc0770685@intel.com>
References: <1508488012-82704-1-git-send-email-jingjing.wu@intel.com>
 <1508488012-82704-9-git-send-email-jingjing.wu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: wenzhuo.lu@intel.com, Olivier MATZ <olivier.matz@6wind.com>
To: Jingjing Wu <jingjing.wu@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 2BF89235
 for <dev@dpdk.org>; Wed, 22 Nov 2017 01:09:11 +0100 (CET)
In-Reply-To: <1508488012-82704-9-git-send-email-jingjing.wu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/20/2017 1:26 AM, Jingjing Wu wrote:
>  - rxq_info_get
>  - txq_info_get
>  - rx_queue_count
>  - rx_descriptor_done
>  - rx_descriptor_status
>  - tx_descriptor_status

+ some documentation.

<...>

> @@ -28,8 +28,8 @@
>      (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
>      OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>  
> -I40E/IXGBE/IGB Virtual Function Driver

AVF doesn't cover ixgbe/igb virtual functions right? Perhaps it can be good to
keep information for them.

<...>

> @@ -132,7 +132,15 @@ static const struct eth_dev_ops avf_eth_dev_ops = {
>  	.reta_query                 = avf_dev_rss_reta_query,
>  	.rss_hash_update            = avf_dev_rss_hash_update,
>  	.rss_hash_conf_get          = avf_dev_rss_hash_conf_get,
> +	.rxq_info_get               = avf_dev_rxq_info_get,
> +	.txq_info_get               = avf_dev_txq_info_get,
> +	.rx_queue_count             = avf_dev_rxq_count,
> +	.rx_descriptor_done         = avf_dev_rx_desc_done,

If you implemented "rx_descriptor_status" no need to implement
"rx_descriptor_done", one covers other.

cc'ed Olivier if I am missing anything.

<...>