From mboxrd@z Thu Jan 1 00:00:00 1970 From: Akhil Goyal Subject: Re: [PATCH v3 00/12] introduce security offload library Date: Tue, 10 Oct 2017 17:52:27 +0530 Message-ID: <5146e24f-99de-d6cf-eb42-b553135de6c7@nxp.com> References: <20171003131413.23846-1-akhil.goyal@nxp.com> <20171006181151.4758-1-akhil.goyal@nxp.com> <2601191342CEEE43887BDE71AB9772585FAA653D@IRSMSX103.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: "Doherty, Declan" , "De Lara Guarch, Pablo" , "hemant.agrawal@nxp.com" , "Nicolau, Radu" , "borisp@mellanox.com" , "aviadye@mellanox.com" , "thomas@monjalon.net" , "sandeep.malik@nxp.com" , "jerin.jacob@caviumnetworks.com" , "Mcnamara, John" , "shahafs@mellanox.com" , "olivier.matz@6wind.com" To: "Ananyev, Konstantin" , "dev@dpdk.org" Return-path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0081.outbound.protection.outlook.com [104.47.38.81]) by dpdk.org (Postfix) with ESMTP id ABA431B201 for ; Tue, 10 Oct 2017 14:22:37 +0200 (CEST) In-Reply-To: <2601191342CEEE43887BDE71AB9772585FAA653D@IRSMSX103.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Konstantin, On 10/9/2017 7:19 PM, Ananyev, Konstantin wrote: > > >> -----Original Message----- >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com] >> Sent: Friday, October 6, 2017 7:12 PM >> To: dev@dpdk.org >> Cc: Doherty, Declan ; De Lara Guarch, Pablo ; hemant.agrawal@nxp.com; >> Nicolau, Radu ; borisp@mellanox.com; aviadye@mellanox.com; thomas@monjalon.net; >> sandeep.malik@nxp.com; jerin.jacob@caviumnetworks.com; Mcnamara, John ; Ananyev, Konstantin >> ; shahafs@mellanox.com; olivier.matz@6wind.com >> Subject: [PATCH v3 00/12] introduce security offload library >> >> This patchset introduce the rte_security library in DPDK. >> This also includes the sample implementation of drivers and >> changes in ipsec gateway application to demonstrate its usage. >> >> >> rte_security library is implemented on the idea proposed earlier [1],[2],[3] >> to support IPsec Inline and look aside crypto offload. Though >> the current focus is only on IPsec protocol, but the library is >> not limited to IPsec, it can be extended to other security >> protocols e.g. MACSEC, PDCP or DTLS. >> >> In this library, crypto/ethernet devices can register itself to >> the security library to support security offload. >> >> The library support 3 modes of operation >> 1. full protocol offload using crypto devices. >> (RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL) >> 2. inline ipsec using ethernet devices to perform crypto operations >> (RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO) >> 3. full protocol offload using ethernet devices. >> (RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL) >> >> The details for each mode is documented in the patchset in >> doc/guides/prog_guide/rte_security.rst >> >> The modification in the application ipsec-secgw is also doocumented in >> doc/guides/sample_app_ug/ipsec_secgw.rst >> >> This patchset is also available at: >> git://dpdk.org/draft/dpdk-draft-ipsec >> branch: integration >> >> changes in v3: >> 1. fixed compilation for FreeBSD >> 2. Incorporated comments from Pablo, John, Shahaf, Ananyev > > As I can see, you didn't address any of my comments in v3. > So please don't include my name here. > Konstantin > > This was a mistake on my part. I thought your comments on ethdev and ixgbe changes were taken care of. I would not repeat this in future. -Akhil