dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: dev-VfR2kkLFssw@public.gmane.org
Cc: "Han, Dongsu" <dongsuh-ETDLCGt7PQU3uPMLIKxrzw@public.gmane.org>
Subject: Re: [PATCH] fixed buffer overrun in handling log messages
Date: Thu, 02 May 2013 11:18:01 +0200	[thread overview]
Message-ID: <51822F49.5040406@6wind.com> (raw)
In-Reply-To: <518222B1.9050003-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

We can even do better, please see my next email (indeed we should not
send patch as attachment).

Olivier

On 05/02/2013 10:24 AM, Olivier MATZ wrote:
> Hi,
>
> Thank you for this patch. You are right, the '\0' is written
> outside the bounds of the buffer. I would suggest a minor modification
> to your patch, please see attachment.
>
> Regards,
> Olivier
>
>
> On 05/01/2013 08:50 PM, Han, Dongsu wrote:
>> I'm sending a proposed patch to fix the buffer overrun problem in
>> handling log messages.
>>
>> Dongsu Han
>>
>>
>> _______________________________________________
>> dev mailing list
>> dev-VfR2kkLFssw@public.gmane.org
>> http://dpdk.org/ml/listinfo/dev
>
>

  parent reply	other threads:[~2013-05-02  9:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-01 18:50 [PATCH] fixed buffer overrun in handling log messages Han, Dongsu
     [not found] ` <CAAYH+dX-4W-ZbmVEogRLMdy0KtT7iG249m18S7inp5TNW0j67g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-02  8:24   ` Olivier MATZ
     [not found]     ` <518222B1.9050003-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-05-02  9:18       ` Olivier MATZ [this message]
     [not found]         ` <51822F49.5040406-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-05-02  9:22           ` eal/log: fix memory corruption Olivier Matz
     [not found]             ` <1367486557-8589-1-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-05-03 16:37               ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51822F49.5040406@6wind.com \
    --to=olivier.matz-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=dongsuh-ETDLCGt7PQU3uPMLIKxrzw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).