From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 1/3] mk: rule showconfigs for configs listing
Date: Fri, 17 May 2013 11:05:54 +0200
Message-ID: <5195F2F2.60107@6wind.com>
References: <cover.1367939814.git.thomas.monjalon@6wind.com>
 <43533094849ffdacde83cad14c59364caa39d595.1367939814.git.thomas.monjalon@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
To: dev-VfR2kkLFssw@public.gmane.org
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <43533094849ffdacde83cad14c59364caa39d595.1367939814.git.thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Thomas,

I wonder if this new rule is really needed: I think you can already
do a "make config" without argument to list the supported
configurations.

Olivier

On 05/07/2013 05:17 PM, Thomas Monjalon wrote:
> Allow to list configs in config/ directory with a simple make rule.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> ---
>  mk/rte.sdkconfig.mk |    4 ++++
>  mk/rte.sdkroot.mk   |    4 ++--
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk
> index ed81c47..179089e 100644
> --- a/mk/rte.sdkconfig.mk
> +++ b/mk/rte.sdkconfig.mk
> @@ -36,6 +36,10 @@ INSTALL_CONFIGS := $(filter-out %~,\
>  	$(wildcard $(RTE_SRCDIR)/config/defconfig_*)))
>  INSTALL_TARGETS := $(addsuffix _install,$(INSTALL_CONFIGS))
>  
> +.PHONY: showconfigs
> +showconfigs:
> +	@$(foreach CONFIG, $(INSTALL_CONFIGS), echo $(CONFIG);)
> +
>  .PHONY: config
>  ifeq ($(RTE_CONFIG_TEMPLATE),)
>  config:
> diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk
> index f555e33..6bbbd54 100644
> --- a/mk/rte.sdkroot.mk
> +++ b/mk/rte.sdkroot.mk
> @@ -87,8 +87,8 @@ export ROOTDIRS-y ROOTDIRS- ROOTDIRS-n
>  .PHONY: default
>  default: all
>  
> -.PHONY: config
> -config:
> +.PHONY: config showconfigs
> +config showconfigs:
>  	$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk $@
>  
>  .PHONY: test fast_test ring_test mempool_test