From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Millescamps Subject: Re: [PATCH 4/7] eal: support different modules Date: Tue, 04 Jun 2013 11:17:21 +0200 Message-ID: <51ADB0A1.7000705@6wind.com> References: <20130530171234.301927271@vyatta.com> <51AC5A99.1050207@6wind.com> <20130603084154.70219c8f@nehalam.linuxnetplumber.net> <201306031836.52362.thomas.monjalon@6wind.com> <20130603102629.713d917c@nehalam.linuxnetplumber.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------070602010307030507000402" To: dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <20130603102629.713d917c-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" This is a multi-part message in MIME format. --------------070602010307030507000402 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 06/03/2013 07:26 PM, Stephen Hemminger wrote: > There is nothing that says a PMD could load a second module, but why no= t put > that special case code in the the driver. Or make it a list of strings. There is nothing that says anything about PMD and loading a single module. However, the Getting Started Guide refers to "dymanic kernel tweaks" citing "modules", all in a plural form: /"Running an Intel=AEDPDK application requires some kernel configuration customization (done at build time) and some dynamic kernel tweaks (modules, procfs)./" A list of strings can be implemented using a "null terminated array", as suggested in my review. So yes, it could be a good solution. --=20 Damien Millescamps --------------070602010307030507000402 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit
On 06/03/2013 07:26 PM, Stephen Hemminger wrote:
There is nothing that says a PMD could load a second module, but why not put
that special case code in the the driver. Or make it a list of strings.
There is nothing that says anything about PMD and loading a single module. However, the Getting Started Guide refers to "dymanic kernel tweaks" citing "modules", all in a plural form:
"Running an Intel®DPDK application requires some kernel configuration customization (done at build time) and some dynamic kernel tweaks (modules, procfs)."

A list of strings can be implemented using a "null terminated array", as suggested in my review. So yes, it could be a good solution.

--
Damien Millescamps
--------------070602010307030507000402--