From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Thomas Monjalon
<thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] ethdev: fix empty struct rte_eth_txmode
Date: Wed, 12 Jun 2013 16:46:10 +0200 [thread overview]
Message-ID: <51B889B2.9050105@6wind.com> (raw)
In-Reply-To: <1371047405-29432-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
On 06/12/2013 04:30 PM, Thomas Monjalon wrote:
> The previous fix was for g++ but is broken with gcc:
> error: flexible array member in otherwise empty struct
> See http://gcc.gnu.org/onlinedocs/gcc-4.2.2/gcc/Zero-Length.html
>
> Let's fix it with #ifdef __cplusplus.
Sorry Thomas for the previous one, I should have tested it.
This one looks good, I checked compilation and it works with
gcc-4.6.3 and g++-4.6.3
next prev parent reply other threads:[~2013-06-12 14:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 12:23 Can the empty struct rte_eth_txmode be enhanced? lxu
[not found] ` <tencent_32A472FE12E181E41F4C6C1C-9uewiaClKEY@public.gmane.org>
2013-06-12 13:39 ` Thomas Monjalon
[not found] ` <201306121539.49552.thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-06-12 14:30 ` [PATCH] ethdev: fix empty struct rte_eth_txmode Thomas Monjalon
[not found] ` <1371047405-29432-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-06-12 14:46 ` Olivier MATZ [this message]
[not found] ` <51B889B2.9050105-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-06-12 15:14 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B889B2.9050105@6wind.com \
--to=olivier.matz-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).