From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vincent JARDIN <vincent.jardin-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 1/2] mk: add rule to print version number
Date: Fri, 19 Jul 2013 21:18:11 +0200
Message-ID: <51E990F3.1020809@6wind.com>
References: <cover.1374243470.git.thomas.monjalon@6wind.com>
 <3bd9ee985e2d0ce0d2780ba0160ecd31bb502878.1374243470.git.thomas.monjalon@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
To: dev-VfR2kkLFssw@public.gmane.org
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <3bd9ee985e2d0ce0d2780ba0160ecd31bb502878.1374243470.git.thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

it is just look n feel, just push it.

Acked-by: vincent.jardin-pdR9zngts4EAvxtiuMwx3w@public.gmane.org

On 19/07/2013 16:19, Thomas Monjalon wrote:
> The version string is extracted from rte_version.h.
> RTE_VER_* macros are concatenated and separators " . . r " are inserted.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> ---
>   mk/rte.sdkconfig.mk |    6 ++++++
>   mk/rte.sdkroot.mk   |    4 ++--
>   2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk
> index 2c071a2..6eb389c 100644
> --- a/mk/rte.sdkconfig.mk
> +++ b/mk/rte.sdkconfig.mk
> @@ -31,6 +31,12 @@
>   #
>   #  version: DPDK.L.1.2.3-3
>
> +.PHONY: showversion
> +showversion:
> +	@sed -rn 's,^#define RTE_VER_[A-Z_]*[[:space:]]+([0-9]+).*,\1,p' \
> +		$(RTE_SRCDIR)/lib/librte_eal/common/include/rte_version.h | \
> +		tr '\n' '.' | sed -r 's,\.([0-9]+)\.$$,r\1\n,'
> +
>   INSTALL_CONFIGS := $(filter-out %~,\
>   	$(patsubst $(RTE_SRCDIR)/config/defconfig_%,%,\
>   	$(wildcard $(RTE_SRCDIR)/config/defconfig_*)))
> diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk
> index 905b678..b5126c0 100644
> --- a/mk/rte.sdkroot.mk
> +++ b/mk/rte.sdkroot.mk
> @@ -87,8 +87,8 @@ export ROOTDIRS-y ROOTDIRS- ROOTDIRS-n
>   .PHONY: default
>   default: all
>
> -.PHONY: config showconfigs
> -config showconfigs:
> +.PHONY: config showconfigs showversion
> +config showconfigs showversion:
>   	$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk $@
>
>   .PHONY: test fast_test ring_test mempool_test
>