From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wiles, Keith" Subject: Re: [PATCH 1/2] ethdev: increase port_id range Date: Wed, 9 Aug 2017 12:57:46 +0000 Message-ID: <5208BC53-1918-4D6A-AE91-7C2936479084@intel.com> References: <20170809084203.17562-1-zhiyong.yang@intel.com> <20170809084203.17562-2-zhiyong.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Yang, Zhiyong" , "dev@dpdk.org" , "thomas@monjalon.net" To: "Yigit, Ferruh" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 130F51B53 for ; Wed, 9 Aug 2017 14:57:48 +0200 (CEST) In-Reply-To: Content-Language: en-US Content-ID: <35ABD059826A414F9725E34815118774@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Aug 9, 2017, at 7:52 AM, Ferruh Yigit wrote: >=20 > On 8/9/2017 9:42 AM, Zhiyong Yang wrote: >> Extend port_id definition from uint8_t to uint16_t in lib >> ethdev data structures, specifically rte_eth_dev_data and >> modify the APIs using port_id at the same time. If we have not already decided, we need to apply this patch very soon to ha= mmer out all of the bugs before the next release. >>=20 >> Signed-off-by: Zhiyong Yang >> --- >> app/pdump/main.c | 2 +- >> app/test-pmd/cmdline.c | 4 +- >> app/test-pmd/testpmd.c | 4 +- >> app/test-pmd/testpmd.h | 2 +- >=20 >> drivers/net/bonding/rte_eth_bond.h | 40 ++--- >> drivers/net/bonding/rte_eth_bond_8023ad.c | 6 +- >> drivers/net/bonding/rte_eth_bond_api.c | 54 +++---- >> drivers/net/bonding/rte_eth_bond_pmd.c | 10 +- >> drivers/net/bonding/rte_eth_bond_private.h | 36 ++--- >> drivers/net/failsafe/failsafe_ether.c | 4 +- >> drivers/net/failsafe/failsafe_private.h | 4 +- >> drivers/net/ring/rte_eth_ring.c | 2 +- >=20 > I would expect more drivers would be effected from this, almost all. >=20 > Most PMDs stores the dev->data->port_in in their private data and use > this value while updating mbuf field, those local storage also should be > updated to u16 to prevent data loss. >=20 > Can you please double check drivers, specially data->port_id usages? > I quickly checked null and pcap for example, both needs to be updated. >=20 > Also PMDs with PMD specific API are getting port_id as parameter, so > they should be updated too. >=20 > And I am getting build error for ixgbe and i40e for log type format, - > via clang. >=20 > Thanks, > ferruh >=20 >> lib/librte_ether/rte_ethdev.c | 231 ++++++++++++++---------= ----- >> lib/librte_ether/rte_ethdev.h | 236 ++++++++++++++---------= ------ >> lib/librte_ether/rte_tm.c | 62 ++++---- >> lib/librte_ether/rte_tm.h | 60 ++++---- >> lib/librte_ether/rte_tm_driver.h | 2 +- >> lib/librte_latencystats/rte_latencystats.c | 8 +- >> lib/librte_pdump/rte_pdump.c | 16 +- >> lib/librte_pdump/rte_pdump.h | 4 +- >> lib/librte_port/rte_port_ethdev.c | 6 +- >> lib/librte_port/rte_port_ethdev.h | 6 +- >> 22 files changed, 404 insertions(+), 395 deletions(-) >=20 > <...> Regards, Keith