From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: Compilation errors in drivers/event/opdl/
Date: Sun, 21 Jan 2018 18:49:13 +0100
Message-ID: <5211400.X7DXXCoju3@xps>
References: <D6881123.1A3A3D%Harish.Patil@cavium.com>
 <20236883.VkVyGBRfOF@xps> <20180121093458.082f4589@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: "Patil, Harish" <Harish.Patil@cavium.com>,
 "liang.j.ma@intel.com" <liang.j.ma@intel.com>,
 "peter.mccarthy@intel.com" <peter.mccarthy@intel.com>,
 jerin.jacob@caviumnetworks.com, dev@dpdk.org, ferruh.yigit@intel.com,
 adrien.mazarguil@6wind.com
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E703DA56E
 for <dev@dpdk.org>; Sun, 21 Jan 2018 18:49:53 +0100 (CET)
In-Reply-To: <20180121093458.082f4589@xeon-e3>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

21/01/2018 18:34, Stephen Hemminger:
> On Sat, 20 Jan 2018 09:44:46 +0100
> Thomas Monjalon <thomas@monjalon.net> wrote:
>=20
> > 20/01/2018 06:18, Patil, Harish:
> > > Hi,
> > >=20
> > > I am seeing below compilation errors in drivers/event/opdl/, this is =
with
> > > cloned latest DPDK (git clone http://dpdk.org/git/dpdk).
> > >=20
> > > ..
> > > ..
> > > /home2/hpatil/e4/jan19-inbox-submit/dpdk/drivers/event/opdl/opdl_evde=
v_xsta
> > > ts.c: In function =C3=A2=E2=82=AC=CB=9Copdl_xstats_get_names=C3=A2=E2=
=82=AC=E2=84=A2:
> > > /home2/hpatil/e4/jan19-inbox-submit/dpdk/drivers/event/opdl/opdl_evde=
v_xsta
> > > ts.c:89:2: error: =C3=A2=E2=82=AC=CB=9Cfor=C3=A2=E2=82=AC=E2=84=A2 lo=
op initial declarations are only allowed in
> > > C99 mode
> > >   for (uint32_t j =3D 0; j < max_num_port_xstat; j++) {
> > >   ^ =20
> >=20
> > My compiler does not raise this error.
> > What is your compiler?
> >=20
> > Anyone to fix it QUICKLY please? today?
> >=20
> > Harish, do you think we should revert if not fixed?
>=20
> Using declaration in for loop is a C++ thing which was inherited into C99.
> Does DPDK require C99 mode?

No DPDK is not generally C99.

> Putting loop variables in for() looks better, but the rest of DPDK
> doesn't use that style.

C99 was forced for this driver as a quick fix.

Either the coding style guideline is updated to C99,
or this driver must be adapted to the DPDK coding style.
I have no strong opinion.

Is C99 well supported in all compilers we want to use (including Windows)?