From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal: force gcc to inline rte_movX function Date: Wed, 18 Apr 2018 09:25:56 +0200 Message-ID: <5237986.PrAvHOT1FH@xps> References: <20180412051636.240746-1-junjie.j.chen@intel.com> <20180417145734.GA89464@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Richardson, Bruce" , "Ananyev, Konstantin" To: "Chen, Junjie J" Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 25F8B803D for ; Wed, 18 Apr 2018 09:25:59 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/04/2018 04:43, Chen, Junjie J: > Thanks to point this out. I agree for the title change. > > Do you want me to send v2 patch? Or you can handle it when committing? > > > > > Sometimes gcc does not inline the function despite keyword *inline*, > > > > we obeserve rte_movX is not inline when doing performance profiling, > > > > so use *always_inline* keyword to force gcc to inline the function. > > > > > > > > Signed-off-by: Chen, Junjie > > > > --- > > > > .../common/include/arch/x86/rte_memcpy.h | 22 > > +++++++++++----------- > > > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > > > The title should start with "eal/x86:" > > > Something like that: > > > eal/x86: force inlining of memcpy sub-functions > > > > > > Bruce, Konstantin, any review of the content/optimization? > > > > > No objection here. > > > > Acked-by: Bruce Richardson Applied, thanks