From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] ethdev: allow all ports event registration
Date: Sat, 30 Dec 2017 21:51:06 +0100
Message-ID: <5248035.SzZHBmRRCd@xps>
References: <1512028170-18637-1-git-send-email-matan@mellanox.com>
 <6214136.ixGVTiWP3P@xps>
 <AM6PR0502MB379715DDE526109D7C648AD0D21A0@AM6PR0502MB3797.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Matan Azrad <matan@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 183B7160
 for <dev@dpdk.org>; Sat, 30 Dec 2017 21:51:22 +0100 (CET)
In-Reply-To: <AM6PR0502MB379715DDE526109D7C648AD0D21A0@AM6PR0502MB3797.eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

30/12/2017 20:04, Matan Azrad:
>  From: Thomas Monjalon, December 29, 2017
> > 04/12/2017 16:43, Matan Azrad:
> > > @@ -2827,37 +2837,59 @@
> > > +	uint32_t next_port;
> > > +	uint32_t last_port;
> > 
> > A port id should be uint16_t.
> > 
> Yes, I know but please note that we use next_port variable in the while statement and it can be rolled in case  the max value of port id is the max value of uint16_t type.
> This is the reason I defined it as uint32_t type.

OK, so I suggest 2 possible fixes:
- either keep uint32_t with a comment in the code.
- or use a for loop

What do you prefer?