From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] vhost/crypto: fix bracket
Date: Mon, 30 Apr 2018 14:57:51 +0200
Message-ID: <5249193.zgQrW8SLgo@xps>
References: <20180430103601.32356-1-roy.fan.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, maxime.coquelin@redhat.com, ferruh.yigit@intel.com
To: Fan Zhang <roy.fan.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 8F5541C0B
 for <dev@dpdk.org>; Mon, 30 Apr 2018 14:57:54 +0200 (CEST)
In-Reply-To: <20180430103601.32356-1-roy.fan.zhang@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

30/04/2018 12:36, Fan Zhang:
> Coverity issue: 233232
> Coverity issue: 233237
> Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>

2 comments, Fan:

1/ I think it the v2 of a previous commit.
Please update the patchwork status (superseded),
use -v option for revision numbering,
and add a changelog.

2/ The title must give the scope of the change,
or give an idea of the impact of the patch.
Example:
	fix symmetric ciphering
The root cause (bracket location) is better in the
commit message than the title.

Thanks