From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v14 1/6] lib: add information metrics library
Date: Wed, 05 Apr 2017 17:06:41 +0200
Message-ID: <5252491.9gF4pOle3c@xps13>
References: <1490907662-27666-1-git-send-email-remy.horton@intel.com>
 <165712131.qiFBceb8LK@xps13> <195ebf71-69a7-fca2-ce95-8912ad7ef51a@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Remy Horton <remy.horton@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f48.google.com (mail-lf0-f48.google.com
 [209.85.215.48]) by dpdk.org (Postfix) with ESMTP id 1B23A1E20
 for <dev@dpdk.org>; Wed,  5 Apr 2017 17:06:44 +0200 (CEST)
Received: by mail-lf0-f48.google.com with SMTP id x137so10944087lff.3
 for <dev@dpdk.org>; Wed, 05 Apr 2017 08:06:43 -0700 (PDT)
In-Reply-To: <195ebf71-69a7-fca2-ce95-8912ad7ef51a@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-04-05 15:46, Remy Horton:
> 
> On 05/04/2017 14:39, Thomas Monjalon wrote:
> > 2017-03-30 22:00, Remy Horton:
> >> --- a/mk/rte.app.mk
> >> +++ b/mk/rte.app.mk
> [..]
> >> +_LDLIBS-$(CONFIG_RTE_LIBRTE_METRICS)        += -lrte_metrics
> >
> > It should not be added here in --whole-archive as it is not going to be
> > used by plugins (drivers).
> >
> > I suggest moving it upper with rte_jobstats.
> 
> Ok.
> 
> As an aside, there seems to have been recent changes to the build 
> system, so I suspect there might be a few redundant Makefile additions 
> lying around the patchset.

Do you mean DEPDIRS-$(CONFIG_RTE_LIBRTE_METRICS) et al?
I can remove them if you confirm.