From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v10] devtools: alert on new instances of rte_panic and rte_exit Date: Sun, 27 May 2018 21:47:20 +0200 Message-ID: <5254321.ZC84c43z8L@xps> References: <1524723664-30510-11-git-send-email-arnon@qwilt.com> <1525070752-21085-1-git-send-email-arnon@qwilt.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com, Neil Horman To: Arnon Warshavsky Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A918B3572 for ; Sun, 27 May 2018 21:47:23 +0200 (CEST) In-Reply-To: <1525070752-21085-1-git-send-email-arnon@qwilt.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, 30/04/2018 08:45, Arnon Warshavsky: > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > + check_forbidden_additions - This is consuming stdin. I guess the checkpatch.pl will have nothing to check in the next step. We should merge Neil's patch first, because he is adding a tmpfile to solve the issue of stdin read only once. > + [ $? -eq 0 ] || return 0 This test looks reversed: if the result is not 0, we should not return 0. And by the way, I think it is better to continue with other checks. Neil's patch is setting ret=1, continue and return at the end. > report=$($DPDK_CHECKPATCH_PATH $options - 2>/dev/null)