From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Rao, Nikhil" <nikhil.rao@intel.com>
Subject: Re: [PATCH] examples/eventdev_pipeline: add Tx adapter
	support
Date: Fri, 21 Sep 2018 13:14:53 +0530
Message-ID: <5261bae8-0842-849e-b95a-67ee851ee7f8@intel.com>
References: <20180905134554.25243-1-pbhagavatula@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, "Rao, Nikhil" <nikhil.rao@intel.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
 jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com,
 anoob.joseph@caviumnetworks.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id A8B81F04
 for <dev@dpdk.org>; Fri, 21 Sep 2018 09:45:14 +0200 (CEST)
In-Reply-To: <20180905134554.25243-1-pbhagavatula@caviumnetworks.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/5/2018 7:15 PM, Pavan Nikhilesh wrote:
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
>   This patch depends on the following series:
>   http://patches.dpdk.org/project/dpdk/list/?series=1121
> 
>   examples/eventdev_pipeline/main.c             |  62 ++--
>   examples/eventdev_pipeline/pipeline_common.h  |  31 +-
>   .../pipeline_worker_generic.c                 | 273 +++++-------------
>   .../eventdev_pipeline/pipeline_worker_tx.c    | 130 +++++----
>   4 files changed, 186 insertions(+), 310 deletions(-)
> 
> --- a/examples/eventdev_pipeline/pipeline_worker_generic.c
> +++ b/examples/eventdev_pipeline/pipeline_worker_generic.c
> @@ -119,153 +119,13 @@ worker_generic_burst(void *arg)
>   	return 0;
>   }
> 

>   static void
> -init_rx_adapter(uint16_t nb_ports)
> +init_adapters(uint16_t nb_ports)
>   {
>   	int i;
>   	int ret;
> +	uint8_t tx_port_id = 0;
>   	uint8_t evdev_id = 0;
>   	struct rte_event_dev_info dev_info;
> 
>   	ret = rte_event_dev_info_get(evdev_id, &dev_info);
> 
> -	struct rte_event_port_conf rx_p_conf = {
> +	struct rte_event_port_conf adptr_p_conf = {
>   		.dequeue_depth = 8,
>   		.enqueue_depth = 8,
>   		.new_event_threshold = 1200,
>   	};
> 

We should restore the dequeue_depth to 128 for the port config passed to 
the Tx adapter. Doing so takes the performance from 5.8 mpps to 11.7 
mpps for on my test setup (test setup uses the SW PMD). Restoring 
enqueue_depth and new_event_threshold (64 and 4096 respectively) had
no noticeable effect.

Thanks,
Nikhil