From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] config: fix combined/shared lib
Date: Wed, 30 Oct 2013 09:53:04 +0100
Message-ID: <5270C8F0.1080306@6wind.com>
References: <1382522765-27254-1-git-send-email-thomas.monjalon@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1382522765-27254-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Thomas,

 > - Configuration for combined and shared library was only in
 >   the template defconfig_x86_64-default-linuxapp-gcc.
> - CONFIG_RTE_LIBNAME was in the wrong section
> - CONFIG_RTE_LIBNAME quotes were not properly removed in "make context"
> - RTE_LIBNAME had no quote in "C context" (include/rte_config.h)

acked

Just one remark about the commit log: if I understand well, the
issue related to the quote not properly removed in "make context"
is triggered by the quotes you added in the defconfig. I would reword
the commit log a bit to highlight it.

Regards,
Olivier