dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] config: remove unused KNI debug option
@ 2013-10-30 15:33 Thomas Monjalon
       [not found] ` <1383147219-2833-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2013-10-30 15:33 UTC (permalink / raw)
  To: dev-VfR2kkLFssw

The option RTE_LIBRTE_KNI_DEBUG has no effect so it should be removed.
The right options are:
- RTE_KNI_KO_DEBUG
- RTE_KNI_VHOST_DEBUG_RX
- RTE_KNI_VHOST_DEBUG_TX

Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
---
 config/defconfig_i686-default-linuxapp-gcc   |    1 -
 config/defconfig_i686-default-linuxapp-icc   |    1 -
 config/defconfig_x86_64-default-linuxapp-gcc |    1 -
 config/defconfig_x86_64-default-linuxapp-icc |    1 -
 4 files changed, 4 deletions(-)

diff --git a/config/defconfig_i686-default-linuxapp-gcc b/config/defconfig_i686-default-linuxapp-gcc
index 1894896..de31dc6 100644
--- a/config/defconfig_i686-default-linuxapp-gcc
+++ b/config/defconfig_i686-default-linuxapp-gcc
@@ -287,7 +287,6 @@ CONFIG_RTE_SCHED_PORT_N_GRINDERS=8
 # KNI is not supported on 32-bit
 #
 CONFIG_RTE_LIBRTE_KNI=n
-CONFIG_RTE_LIBRTE_KNI_DEBUG=n
 CONFIG_RTE_KNI_KO_DEBUG=n
 CONFIG_RTE_KNI_VHOST=n
 CONFIG_RTE_KNI_VHOST_MAX_CACHE_SIZE=1024
diff --git a/config/defconfig_i686-default-linuxapp-icc b/config/defconfig_i686-default-linuxapp-icc
index b100560..238e488 100644
--- a/config/defconfig_i686-default-linuxapp-icc
+++ b/config/defconfig_i686-default-linuxapp-icc
@@ -286,7 +286,6 @@ CONFIG_RTE_SCHED_PORT_N_GRINDERS=8
 # KNI is not supported on 32-bit
 #
 CONFIG_RTE_LIBRTE_KNI=n
-CONFIG_RTE_LIBRTE_KNI_DEBUG=n
 CONFIG_RTE_KNI_KO_DEBUG=n
 CONFIG_RTE_KNI_VHOST=n
 CONFIG_RTE_KNI_VHOST_MAX_CACHE_SIZE=1024
diff --git a/config/defconfig_x86_64-default-linuxapp-gcc b/config/defconfig_x86_64-default-linuxapp-gcc
index cb8e405..54337a8 100644
--- a/config/defconfig_x86_64-default-linuxapp-gcc
+++ b/config/defconfig_x86_64-default-linuxapp-gcc
@@ -286,7 +286,6 @@ CONFIG_RTE_SCHED_PORT_N_GRINDERS=8
 # Compile librte_kni
 #
 CONFIG_RTE_LIBRTE_KNI=y
-CONFIG_RTE_LIBRTE_KNI_DEBUG=n
 CONFIG_RTE_KNI_KO_DEBUG=n
 CONFIG_RTE_KNI_VHOST=n
 CONFIG_RTE_KNI_VHOST_MAX_CACHE_SIZE=1024
diff --git a/config/defconfig_x86_64-default-linuxapp-icc b/config/defconfig_x86_64-default-linuxapp-icc
index 167ed74..931a1a7 100644
--- a/config/defconfig_x86_64-default-linuxapp-icc
+++ b/config/defconfig_x86_64-default-linuxapp-icc
@@ -285,7 +285,6 @@ CONFIG_RTE_SCHED_PORT_N_GRINDERS=8
 # Compile librte_kni
 #
 CONFIG_RTE_LIBRTE_KNI=y
-CONFIG_RTE_LIBRTE_KNI_DEBUG=n
 CONFIG_RTE_KNI_KO_DEBUG=n
 CONFIG_RTE_KNI_VHOST=n
 CONFIG_RTE_KNI_VHOST_MAX_CACHE_SIZE=1024
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] config: remove unused KNI debug option
       [not found] ` <1383147219-2833-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
@ 2013-11-07  9:35   ` Olivier MATZ
       [not found]     ` <527B5EE0.8050902-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Olivier MATZ @ 2013-11-07  9:35 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev-VfR2kkLFssw

Hi,

On 10/30/2013 04:33 PM, Thomas Monjalon wrote:
> The option RTE_LIBRTE_KNI_DEBUG has no effect so it should be removed.
> The right options are:
> - RTE_KNI_KO_DEBUG
> - RTE_KNI_VHOST_DEBUG_RX
> - RTE_KNI_VHOST_DEBUG_TX
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Acked-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] config: remove unused KNI debug option
       [not found]     ` <527B5EE0.8050902-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
@ 2013-11-07 10:59       ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2013-11-07 10:59 UTC (permalink / raw)
  To: dev-VfR2kkLFssw

> > The option RTE_LIBRTE_KNI_DEBUG has no effect so it should be removed.
> > The right options are:
> > - RTE_KNI_KO_DEBUG
> > - RTE_KNI_VHOST_DEBUG_RX
> > - RTE_KNI_VHOST_DEBUG_TX
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> 
> Acked-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

pushed

-- 
Thomas

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-11-07 10:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-30 15:33 [PATCH] config: remove unused KNI debug option Thomas Monjalon
     [not found] ` <1383147219-2833-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-11-07  9:35   ` Olivier MATZ
     [not found]     ` <527B5EE0.8050902-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-11-07 10:59       ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).