[PATCH] librte_eal: Add fscanf return value test

[PATCH] librte_eal: Add fscanf return value test

[Tomasz Kulasek]

The lack of result checking of fscanf function, brakes compilation for default 
"-Werror=unused-result" flag.

Signed-off-by: Tomasz Kulasek <tomaszx.kulasek-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 lib/librte_eal/linuxapp/eal/eal.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
index 648ef81..f99e158 100644
--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c
@@ -865,6 +865,7 @@ rte_eal_check_module(const char *module_name)
 {
 	char mod_name[30]; /* Any module names can be longer than 30 bytes? */
 	int ret = 0;
+	int n;
 
 	if (NULL == module_name)
 		return -1;
@@ -876,8 +877,8 @@ rte_eal_check_module(const char *module_name)
 		return -1;
 	}
 	while (!feof(fd)) {
-		fscanf(fd, "%29s %*[^\n]", mod_name);
-		if (!strcmp(mod_name, module_name)) {
+		n = fscanf(fd, "%29s %*[^\n]", mod_name);
+		if ((n == 1) && !strcmp(mod_name, module_name)) {
 			ret = 1;
 			break;
 		}
-- 
1.7.9.5

--------------------------------------------------------------
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

Re: [PATCH] librte_eal: Add fscanf return value test

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Tomasz Kulasek
> Sent: Friday, January 16, 2015 2:28 PM
> To: dev-VfR2kkLFssw@public.gmane.org
> Subject: [dpdk-dev] [PATCH] librte_eal: Add fscanf return value test
> 
> The lack of result checking of fscanf function, brakes compilation for default
> "-Werror=unused-result" flag.
> 
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Acked-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Re: [PATCH] librte_eal: Add fscanf return value test

[Thomas Monjalon]

> > The lack of result checking of fscanf function, brakes compilation for default
> > "-Werror=unused-result" flag.
> > 
> > Signed-off-by: Tomasz Kulasek <tomaszx.kulasek-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Applied

Thanks
-- 
Thomas