From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/1] ethdev: distinguish between drop and error stats Date: Tue, 03 Nov 2015 14:55:33 +0100 Message-ID: <5290737.oElNeekJhY@xps13> References: <1445257253-3673-1-git-send-email-maryam.tahhan@intel.com> <3108772.cu7MlmvWl0@xps13> <1A27633A6DA49C4A92FCD5D4312DBF536A5E618C@IRSMSX109.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Tahhan, Maryam" Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 56AB08DAA for ; Tue, 3 Nov 2015 14:56:44 +0100 (CET) Received: by wicll6 with SMTP id ll6so70170086wic.0 for ; Tue, 03 Nov 2015 05:56:44 -0800 (PST) In-Reply-To: <1A27633A6DA49C4A92FCD5D4312DBF536A5E618C@IRSMSX109.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-11-03 13:14, Tahhan, Maryam: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > There was not a lot of comments on this proposal. > > If the idea is well received, it needs to be implemented in drivers, at least few > > of them. > > Hi Thomas > I was waiting to implement it across the drivers when I knew it was going to be merged to master. It shouldn't break anything that's currently using ethdev stats and should be relatively straight forward to implement for the drivers. Does it makes sense to add it into drivers now or wait for the next open DPDK window? It's better to change API only when it is used by some drivers. We can wait the release 2.3 to integrate it.