From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] doc: note a pitfall on reconnect feature Date: Fri, 22 Jul 2016 18:06:40 +0200 Message-ID: <5291738.m2lUS8501i@xps13> References: <1468901869-29609-1-git-send-email-yuanhan.liu@linux.intel.com> <20160720010835.GO5146@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "Mcnamara, John" , dev@dpdk.org To: Yuanhan Liu Return-path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id CEB03559A for ; Fri, 22 Jul 2016 18:06:41 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id f65so62972501wmi.0 for ; Fri, 22 Jul 2016 09:06:41 -0700 (PDT) In-Reply-To: <20160720010835.GO5146@yliu-dev.sh.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-07-20 09:08, Yuanhan Liu: > On Tue, Jul 19, 2016 at 01:57:11PM +0000, Mcnamara, John wrote: > > > - Note: the "reconnect" feature requires **QEMU v2.7** (or above). > > > + .. Note:: > > > + * The "reconnect" feature requires **QEMU v2.7** (or above). > > > + > > > + * The vhost supported features must be exactly the same before and > > > + after the restart. For example, if TSO is disabled and then > > > enabled, > > > + nothing will work and issues undefined might happen. > > > > s/ issues undefined / undefined issues / > > Thomas, mind to fix it while apply? Yes > > Apart from that: > > > > Acked-by: John McNamara > > Thanks! Applied, thanks