From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] mk: fix libs installation when installing sdk
Date: Fri, 15 Dec 2017 11:32:12 +0100
Message-ID: <5295568.lEBEY0ou7Q@xps>
References: <20171214142411.25375-1-olivier.matz@6wind.com>
 <7350468.cg4rjIInEc@xps> <20171215102516.ltn5uhrglvvnb66e@platinum>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Samuel Gauthier <samuel.gauthier@6wind.com>
To: Olivier MATZ <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A65664A63
 for <dev@dpdk.org>; Fri, 15 Dec 2017 11:32:13 +0100 (CET)
In-Reply-To: <20171215102516.ltn5uhrglvvnb66e@platinum>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

15/12/2017 11:25, Olivier MATZ:
> On Fri, Dec 15, 2017 at 11:19:57AM +0100, Thomas Monjalon wrote:
> > 14/12/2017 15:24, Olivier Matz:
> > > @@ -157,6 +157,8 @@ install-sdk:
> > >  	$(Q)cp -a               $O/.config               $(DESTDIR)$(targetdir)
> > >  	$(Q)cp -a               $O/app/dpdk-pmdinfogen   $(DESTDIR)$(targetdir)/app
> > >  	$(Q)$(call rte_symlink, $(DESTDIR)$(includedir), $(DESTDIR)$(targetdir)/include)
> > > +	$(Q)$(call rte_mkdir,                            $(DESTDIR)$(libdir))
> > > +	$(Q)cp -a               $O/lib/*                 $(DESTDIR)$(libdir)
> > >  	$(Q)$(call rte_symlink, $(DESTDIR)$(libdir),     $(DESTDIR)$(targetdir)/lib)
> > 
> > The libs are already installed with "make install-runtime".
> > Either we add a dependency between install-sdk and install-runtime,
> > or we clearly document it.
> 
> To me, libs are needed when installing the sdk (to compile against them)
> and when installing the runtime (to use them).
> 
> Is it a problem to have it in both targets?

Yes it is a problem because the general use is to call every targets,
so the libs will be installed twice. Look at the global "install" target.

Do you want to be able to install the SDK without the runtime?