From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 6/6] doc: advertise bucket mempool driver
Date: Thu, 26 Apr 2018 00:04:27 +0200
Message-ID: <5302029.6bfcN0d6QB@xps>
References: <1511539591-20966-1-git-send-email-arybchenko@solarflare.com>
 <1524673942-22726-7-git-send-email-arybchenko@solarflare.com>
 <4297121.oP7HX5CK1i@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Olivier MATZ <olivier.matz@6wind.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id AC0E4AAB3
 for <dev@dpdk.org>; Thu, 26 Apr 2018 00:04:29 +0200 (CEST)
In-Reply-To: <4297121.oP7HX5CK1i@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

25/04/2018 23:56, Thomas Monjalon:
> Usually it is better to update the release notes in the main patch
> implementing the feature (probably the first one in this case).
> You can also update it step by step in several patches.
> 
> 25/04/2018 18:32, Andrew Rybchenko:
> > --- a/doc/guides/rel_notes/release_18_05.rst
> > +++ b/doc/guides/rel_notes/release_18_05.rst
> > @@ -147,7 +147,15 @@ New Features
> >    compatible with virtio 0.95 and 1.0. This driver registers ifcvf vDPA driver
> >    to vhost lib, when virtio connected, with the help of the registered vDPA
> >    driver the assigned VF gets configured to Rx/Tx directly to VM's virtio
> > -  vrings.
> 
> Removing this last word is probably a mistake.
> 
> > +
> > +* **Added bucket mempool driver.**
> > +
> > +  Added bucket mempool driver which provides a way to allocate contiguous
> > +  block of objects.
> > +  Number of objects in the block depends on how many objects fit in
> > +  RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB memory chunk which is build time option.
> > +  The number may be obtained using rte_mempool_ops_get_info() API.
> > +  Contiguous blocks may be allocated using rte_mempool_get_contig_blocks() API.

Please add this feature at the beginning of the list (as the first one).

If possible, I would prefer you rebase on top of the mainline
(looks to be next-net here).

Thanks and sorry for nit-picking, I'm testing your stamina :)