From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 02/15] eal/soc: add rte_eal_soc_register/unregister logic Date: Thu, 15 Sep 2016 16:09:20 +0200 Message-ID: <5302721.bs0Wxs4nOl@xps13> References: <1451682326-5834-1-git-send-email-viktorin@rehivetech.com> <84c34eed-b2cb-5cbe-883c-dbbe3741e35f@intel.com> <20160915150930.6e381c85@pcviktorin.fit.vutbr.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, hemant.agrawal@nxp.com To: Jan Viktorin , "Hunt, David" , Shreyansh Jain Return-path: Received: from mail-qt0-f172.google.com (mail-qt0-f172.google.com [209.85.216.172]) by dpdk.org (Postfix) with ESMTP id E701B56A1 for ; Thu, 15 Sep 2016 16:09:22 +0200 (CEST) Received: by mail-qt0-f172.google.com with SMTP id 93so25421243qtg.2 for ; Thu, 15 Sep 2016 07:09:22 -0700 (PDT) In-Reply-To: <20160915150930.6e381c85@pcviktorin.fit.vutbr.cz> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-09-15 15:09, Jan Viktorin: > On Thu, 15 Sep 2016 14:00:25 +0100 > "Hunt, David" wrote: > > > > new file mode 100644 > > > index 0000000..56135ed > > > --- /dev/null > > > +++ b/lib/librte_eal/common/eal_common_soc.c > > > @@ -0,0 +1,56 @@ > > > +/*- > > > + * BSD LICENSE > > > + * > > > + * Copyright(c) 2016 RehiveTech. All rights reserved. > > > + * All rights reserved. > > > > Duplicate "All rights reserved" > > This is present in many source files in DPDK... I don't know why. > > lib/librte_eal/common/eal_common_pci.c > lib/librte_eal/common/eal_common_dev.c > ... It would deserve a dedicated thread to discuss legal sense of these things. I'm not a lawyer but I think "All rights reserved." has no real sense.