From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] examples/l3fwd: force CRC stripping for i40evf Date: Wed, 09 Nov 2016 11:22:27 +0100 Message-ID: <5303716.ypxckaOVgo@xps13> References: <20161109082341.19825-1-bjorn.topel@intel.com> <2601191342CEEE43887BDE71AB9772583F0D2F6C@irsmsx105.ger.corp.intel.com> <5ad83b54-f13b-787e-c056-958f5cb8bd61@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: "Ananyev, Konstantin" , dev@dpdk.org, helin.zhang@intel.com, "Xu, Qian Q" , "Yao, Lei A" , "Wu, Jingjing" To: =?ISO-8859-1?Q?Bj=F6rn_T=F6pel?= Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id CBB612BC7 for ; Wed, 9 Nov 2016 11:22:29 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id p190so298555915wmp.1 for ; Wed, 09 Nov 2016 02:22:29 -0800 (PST) In-Reply-To: <5ad83b54-f13b-787e-c056-958f5cb8bd61@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-11-09 11:05, Bj=F6rn T=F6pel: > > BTW, all other examples would experience same problem too, right? >=20 > Correct, so the broader question would be "what is the correct behavi= or=20 > for an example application, when a port configuration isn't supported= by=20 > the hardware?". >=20 > My stand, FWIW, is that igb and ixgbe should have the same semantics = as > i40e currently has, i.e. return an error to the user if the port is > mis-configured, NOT changing the setting behind the users back. Yes it sounds sane.