From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: doc: deprecation notice for ethdev ops? Date: Mon, 13 Feb 2017 18:39:25 +0100 Message-ID: <53116045.9rx8z4L4Mf@xps13> References: <3EB4FA525960D640B5BDFFD6A3D891265274BEE4@IRSMSX108.ger.corp.intel.com> <3EB4FA525960D640B5BDFFD6A3D891265274C023@IRSMSX108.ger.corp.intel.com> <894e4d0b-9541-c374-eabb-a1e0320e7347@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Ferruh Yigit , dev@dpdk.org, "Richardson, Bruce" , "Wiles, Keith" To: "Dumitrescu, Cristian" Return-path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 206A669C5 for ; Mon, 13 Feb 2017 18:39:27 +0100 (CET) Received: by mail-wm0-f43.google.com with SMTP id t18so8080251wmt.0 for ; Mon, 13 Feb 2017 09:39:27 -0800 (PST) In-Reply-To: <894e4d0b-9541-c374-eabb-a1e0320e7347@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-02-13 17:36, Ferruh Yigit: > On 2/13/2017 5:21 PM, Dumitrescu, Cristian wrote: > > Do you have a specific example that might cause an issue when adding a new function at the end of the ethdev ops structure? I cannot think of any, given that the ops structure is marked as internal and it is only accessed through pointers. > > Adding at the end of the struct is probably safe. There is no guarantee in DPDK for drivers interface compatibility. You can add your op anywhere relevant in the structure.