From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH 09/11] device-args: replace use-device eal option by pci-whitelist and vdev Date: Tue, 04 Mar 2014 14:09:21 +0100 Message-ID: <5315D081.20506@6wind.com> References: <1393608350-4431-1-git-send-email-olivier.matz@6wind.com> <1393608350-4431-10-git-send-email-olivier.matz@6wind.com> <59AF69C657FD0841A61C55336867B5B01A9A16C7@IRSMSX103.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev-VfR2kkLFssw@public.gmane.org" To: "Richardson, Bruce" Return-path: In-Reply-To: <59AF69C657FD0841A61C55336867B5B01A9A16C7-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Bruce, On 03/03/2014 06:14 PM, Richardson, Bruce wrote: >> Subject: [dpdk-dev] [PATCH 09/11] device-args: replace use-device eal >> option by pci-whitelist and vdev >> > Reviewing the patch set, most of the changes make sense to me. This > one I've a few comments on. OK, thank you for your review. > Is it really necessary and beneficial to split the --use-device option > into two, and have two different ways for specifying the devices to > use, based on whether they are pci or virtual devices? An alternative > suggestion/idea: keep a common flag (be it --use-device, or something > else) to specify a device to use and that device's parameters, for all > device types, pretty much as now. Then, to solve the issue of not > being able to use blacklisting plus virtual devices, that could be > solved by adding the --pci-whitelist like you suggest, except instead > of specifying the devices there, it simply means that only the pci > devices passed to use-device get used. Without --pci-whitelist, all > pci devices get used, whether or not they are explicitly called out > with --use-device? My initial concern was that --use-device has 2 different significations, depending on the format of arguments: - instanciate a virtual driver if it looks like a vdev name - add a PCI device to the whitelist if it looks like a pci address I also find strange that instanciating a virtual device changes the PCI mode to whitelist, even if it could be fixed by adding a specific argument for that. Splitting into two different options looked clearer to me, but this is of course not a blocking issue for me. Regards, Olivier