From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH] mk: fix dependencies when modifying config Date: Wed, 26 Mar 2014 17:08:05 +0100 Message-ID: <5332FB65.3000708@6wind.com> References: <1395228982-24858-1-git-send-email-thomas.monjalon@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon Return-path: In-Reply-To: <1395228982-24858-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Thomas, On 03/19/2014 12:36 PM, Thomas Monjalon wrote: > If .config file is changed and .depdirs was built before, > it must be updated. > It is now done silently (-s) in checkconfig rule. > Now .depdirs is not redone if .config is older. > > It has been tested by enabling PMD_PCAP after a default build. > KVARGS dependency should appear in .depdirs. > > Signed-off-by: Thomas Monjalon > --- Looks good to me. Just see one comment below. > # use a "for" in a shell to process dependencies: we don't want this > # task to be run in parallel. > ..PHONY: depdirs It seems there is a typo (..PHONY instead of .PHONY), it could be a good occasion to fix it. In my opinion, it can be done in the same patch as this typo does not create a real issue. Regards, Olivier