From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [memnic PATCH 1/5] pmd: fix race condition
Date: Wed, 26 Mar 2014 17:44:23 +0100
Message-ID: <533303E7.8050206@6wind.com>
References: <7F861DC0615E0C47A872E6F3C5FCDDBD01073AD6@BPXM14GP.gisp.nec.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-2022-JP
Content-Transfer-Encoding: 7bit
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>, Hayato Momma <h-momma-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org>
To: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD01073AD6-ZmjkEB1lVlLt6d3pZDjeaEtBU8KWyXPq@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Hiroshi-san,

Please see my comments below.

On 03/11/2014 06:37 AM, Hiroshi Shimamoto wrote:
> From: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
> 
> There is a race condition, on transmit to vSwitch.

I think we should not talk specifically about vSwitch, as
another implementation of host memnic is possible. Maybe using
the term "host" is more appropriate?

> +		if (idx != ACCESS_ONCE(adapter->down_idx)) {
> +			/*
> +			 * vSwitch freed this and got false positive,
> +			 * need to recover the status and retry.
> +			 */
> +			p->status = MEMNIC_PKT_ST_FREE;
> +			goto retry;
> +		}
> +

The patch indeed looks to improve reliability, even if it's
difficult to me to be sure that there is no other race condition.
Again, I would replace "vSwitch" by "host".

By the way, I guess the Linux code in linux/memnic_net.c should be
modified in the same way.

Regards,
Olivier