From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [memnic PATCH 13/16] pmd: rename doc when installing Date: Thu, 27 Mar 2014 09:36:03 +0100 Message-ID: <5333E2F3.6060503@6wind.com> References: <1391529271-24606-1-git-send-email-thomas.monjalon@6wind.com> <1391529271-24606-14-git-send-email-thomas.monjalon@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon Return-path: In-Reply-To: <1391529271-24606-14-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Thomas, On 02/04/2014 04:54 PM, Thomas Monjalon wrote: > MEMNIC doc may be installed with other DPDK docs. > So more descriptive naming is required. > > A rule is created in order to have the same rule style for lib and doc. > > Signed-off-by: Thomas Monjalon > --- > pmd/Makefile | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/pmd/Makefile b/pmd/Makefile > index 7f96af1..1e24a15 100644 > --- a/pmd/Makefile > +++ b/pmd/Makefile [...] > +install : $(DESTDIR)$(docdir)/$(DOC) > +$(DESTDIR)$(docdir)/$(DOC) : $S/README.rst > + install -D -m 644 $< $@ > + What about renaming README.rst in dpdk-memnic.rst in source ? The rest of the patch looks good to me. Reviewed-by: Olivier Matz