From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH] lib/librte_cmdline: fix CLI parsing issue Date: Mon, 01 May 2017 00:18:47 +0200 Message-ID: <5335581.HtrMrUQc5L@xps> References: <1493089885-94889-1-git-send-email-wenzhuo.lu@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B59DB03@shsmsx102.ccr.corp.intel.com> <20170428111325.7f0d2ab2@platinum> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: stable@dpdk.org, Olivier Matz , "Glynn, Michael J" , "Liu, Yu Y" , dev@dpdk.org To: "Lu, Wenzhuo" Return-path: In-Reply-To: <20170428111325.7f0d2ab2@platinum> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/04/2017 11:13, Olivier Matz: > Hi Wenzhuo, > > On Fri, 28 Apr 2017 08:38:21 +0000, "Lu, Wenzhuo" wrote: > > Hi Oilvier, > > As we discussed before, I send this patch. Would you like to take a look at it? Better fix it before release 17.05, thanks. > > > > > > > When parsing a CLI, all the CLI instances are checked one by one. Even if an > > > instance already matches the CLI, the parsing will not stop for ambiguous > > > check. > > > The problem is that the following check may change the parsing result of the > > > previous one even if the following instance doesn't match. > > > > > > Use a temporary validate for the parsing result when trying to match an > > > instance and only store the result when it matches, so the previous result > > > has no chance to be changed. > > > > > > Fixes: af75078fece3 ("first public release") > > > CC: stable@dpdk.org > > > > > > Signed-off-by: Wenzhuo Lu > > Sorry for the delay, > > Acked-by: Olivier Matz Applied, thanks