From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Graf Subject: Re: [vmxnet3-usermap PATCH 07/16] pkg: add recipe for RPM Date: Wed, 02 Apr 2014 13:07:58 +0200 Message-ID: <533BEF8E.1050801@redhat.com> References: <1391529271-24606-1-git-send-email-thomas.monjalon@6wind.com> <1391529271-24606-8-git-send-email-thomas.monjalon@6wind.com> <530DEA9C.8060101@redhat.com> <1559189.Xkxy3b07km@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon Return-path: In-Reply-To: <1559189.Xkxy3b07km@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 04/02/2014 12:08 PM, Thomas Monjalon wrote: > 2014-02-26 14:22, Thomas Graf: >> On 02/04/2014 04:54 PM, Thomas Monjalon wrote: >>> +BuildRequires: dpdk-core-devel, kernel-devel, kernel-headers >>> +Requires: dpdk-core-runtime >> >> How does the compatibility mapping look like? I assume a given vmxnet3 >> version can only be linked against certain dpdk versions? We need to >> encode that mapping in the spec file somehow. > > Since vmxnet3-usermap-1.1, any dpdk >= 1.3 is supported. > But RPM packaging is not supported for these old versions. > So do you think it's needed to encode a restriction for these old versions? The restriction is only needed if RPM packages for these old versions actually exist. On a more general note: While it is extremely nice to have this spec file to ease the building process. Fedora does not allow inclusion of external kernel modules: https://fedoraproject.org/wiki/Packaging:Guidelines#No_External_Kernel_Modules