From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 6/6] Move common functions in eal_memory.c Date: Mon, 05 Jan 2015 13:17:23 -0800 (PST) Message-ID: <5340807.22YuSvaAXs@xps13> References: <1419957384-11693-1-git-send-email-rkerur@gmail.com> <1419957440-11767-1-git-send-email-rkerur@gmail.com> <1419957440-11767-6-git-send-email-rkerur@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Ravi Kerur Return-path: In-Reply-To: <1419957440-11767-6-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-12-30 11:37, Ravi Kerur: > Use common function names rte_eal_hugepage_init and > rte_eal_hugepage_attach for BSD and Linux. I'd like to be sure that using hugepage wording instead of contigmem is not too weird for BSD people. Do not forget that we have a kernel module called contigmem. Here, an ifdef or a wrapper seems appropriate to keep right wording. -- Thomas