From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] net/af_packet: fix build failure because of
 unused parameter
Date: Mon, 25 Sep 2017 09:42:56 +0100
Message-ID: <535fdb9a-f892-afcd-77e5-4f87e68e2024@intel.com>
References: <1506322206-30233-1-git-send-email-arybchenko@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Chas Williams <chas3@att.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 733D0F94
 for <dev@dpdk.org>; Mon, 25 Sep 2017 10:42:59 +0200 (CEST)
In-Reply-To: <1506322206-30233-1-git-send-email-arybchenko@solarflare.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/25/2017 7:50 AM, Andrew Rybchenko wrote:
> Failure happens on build using:
> gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4)

Yes, that case is missed. What do you think about following one:

  @@ -561,7 +561,7 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
                          unsigned int blockcnt,
                          unsigned int framesize,
                          unsigned int framecnt,
  -                      unsigned int qdisc_bypass,
  +                      unsigned int qdisc_bypass __rte_unused,
                          struct pmd_internals **internals,
                          struct rte_eth_dev **eth_dev,
                          struct rte_kvargs *kvlist)

> 
> Fixes: 0d16c17ae7a4 ("net/af_packet: make qdisc bypass configurable")
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> May be the right solution in fact remove PACKET_QDISC_BYPASS conditional
> completely. If below solution is accepted, feel free to squash it into
> the original patch.

It is a little to late for this, I already sent a pull-request with this
patch. So fix will need to be a separate patch.

<...>