From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 5/8] vhost: claim that we support GUEST_ANNOUNCE feature Date: Fri, 11 Mar 2016 14:16:36 +0100 Message-ID: <5375042.yDKAvMJ3bF@xps13> References: <1450321921-27799-1-git-send-email-yuanhan.liu@linux.intel.com> <1454043483-24579-6-git-send-email-yuanhan.liu@linux.intel.com> <56E2BC8A.8070801@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Olivier MATZ Return-path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 50E3C2B98 for ; Fri, 11 Mar 2016 14:18:41 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id l68so18370216wml.0 for ; Fri, 11 Mar 2016 05:18:41 -0800 (PST) In-Reply-To: <56E2BC8A.8070801@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-11 13:39, Olivier MATZ: > I'm trying to compile the dpdk on an debian-7, and it fails due > to this patch. Indeed, the define VIRTIO_NET_F_GUEST_ANNOUNCE is > not present in /usr/include/linux/virtio_net.h on this distribution. It will be fixed by this patch: http://dpdk.org/dev/patchwork/patch/11195/ > I'm wondering if the librte_vhost shouldn't embed its own version > of virtio_net.h instead of relying on the one from the distribution. > It seems it has been done this way for the virtio guest PMD in > dpdk.org/drivers/net/virtio/virtio_pci.h. > > What do you think?