From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] ethdev: remove experimental flag of ports
	enumeration
Date: Wed, 25 Apr 2018 12:29:45 +0200
Message-ID: <5375928.IW2qTYUPX7@xps>
References: <20180424021511.17430-1-thomas@monjalon.net>
 <8341c868-bab3-44b7-a870-bc07af9828db@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E9AC75593
 for <dev@dpdk.org>; Wed, 25 Apr 2018 12:29:47 +0200 (CEST)
In-Reply-To: <8341c868-bab3-44b7-a870-bc07af9828db@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

25/04/2018 12:21, Ferruh Yigit:
> On 4/24/2018 3:15 AM, Thomas Monjalon wrote:
> > The basic operations for ports enumeration should not be
> > considered as experimental in DPDK 18.05.
> >=20
> > The iterator RTE_ETH_FOREACH_DEV was introduced in DPDK 17.05.
> > It uses the function the rte_eth_find_next_owned_by() to get
> > only ownerless ports. Its API can be considered stable.
> > So the flag experimental is removed from rte_eth_find_next_owned_by().
> >=20
> > The flag experimental is removed from rte_eth_dev_count_avail()
> > which is the new name of the old function rte_eth_dev_count().
> >=20
> > The flag experimental is set to rte_eth_dev_count_total()
> > in the .c file for consistency with the declaration in the .h file.
> >=20
> > A lot of internal applications are fixed to not allow experimental API.
> >=20
> > Fixes: 8728ccf37615 ("fix ethdev ports enumeration")
> > Fixes: d9a42a69febf ("ethdev: deprecate port count function")
> > Fixes: e70e26861eaf ("net/mvpp2: fix build")
> >=20
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>=20
> Getting some build errors [1], it seems some samples are using some other
> experimental APIs so that we can't remove the flag for them.
>=20
>=20
> [1]
> .../dpdk/examples/tep_termination/main.c: In function =E2=80=98main=E2=80=
=99:
> .../dpdk/examples/tep_termination/main.c:1209:3: error: =E2=80=98rte_ctrl=
_thread_create=E2=80=99
> is deprecated: Symbol is not yet part of stable ABI
> [-Werror=3Ddeprecated-declarations]
>    ret =3D rte_ctrl_thread_create(&tid, "print-stats", NULL,
>    ^~~
>=20
> .../dpdk/examples/vhost/main.c: In function =E2=80=98main=E2=80=99:
> .../dpdk/examples/vhost/main.c:1497:3: error: =E2=80=98rte_ctrl_thread_cr=
eate=E2=80=99 is
> deprecated: Symbol is not yet part of stable ABI [-Werror=3Ddeprecated-de=
clarations]
>    ret =3D rte_ctrl_thread_create(&tid, "print-stats", NULL,
>    ^~~

Ah sorry, I think it is due to a change in next-net.
I have prepared this patch on master.

Please can you fix it when applying?