From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Stephen Hemminger
<stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>,
dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH 3/5] mempool: add walk iterator
Date: Fri, 16 May 2014 14:36:44 +0200 [thread overview]
Message-ID: <5376065C.8080005@6wind.com> (raw)
In-Reply-To: <20140502234404.328560724-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
Hi Stephen,
> +void rte_mempool_walk(void (*func)(const struct rte_mempool *, void *),
> + void *arg)
> +{
> + struct rte_mempool *mp = NULL;
> + struct rte_mempool_list *mempool_list;
> +
> + if ((mempool_list =
> + RTE_TAILQ_LOOKUP_BY_IDX(RTE_TAILQ_MEMPOOL, rte_mempool_list)) == NULL) {
> + rte_errno = E_RTE_NO_TAILQ;
> + return;
> + }
At the first read, I thought it was better to return -E_RTE_NO_TAILQ
instead of returning void and setting rte_errno. But it seems it's the
usage, for instance in rte_ring_list_dump().
Acked-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
next prev parent reply other threads:[~2014-05-16 12:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 23:42 [PATCH 0/5] Various patches to 1.6.0r2 Stephen Hemminger
2014-05-02 23:42 ` [PATCH 1/5] spelling fixes Stephen Hemminger
2014-05-02 23:42 ` [PATCH 2/5] dont inline string functions Stephen Hemminger
2014-05-02 23:42 ` [PATCH 3/5] mempool: add walk iterator Stephen Hemminger
[not found] ` <20140502234404.328560724-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2014-05-16 12:36 ` Olivier MATZ [this message]
2014-05-02 23:42 ` [PATCH 4/5] memzone: add iterator function Stephen Hemminger
[not found] ` <20140502234406.153584277-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2014-05-06 9:17 ` Burakov, Anatoly
[not found] ` <C6ECDF3AB251BE4894318F4E45123697592AB62B-kPTMFJFq+rF9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-05-07 16:33 ` Stephen Hemminger
2014-05-16 12:38 ` Olivier MATZ
2014-05-02 23:42 ` [PATCH 5/5] add FILE arguement to debug functions Stephen Hemminger
[not found] ` <20140502234407.841791092-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2014-05-04 12:20 ` Neil Horman
[not found] ` <20140504122053.GA5012-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-05-04 20:17 ` Stephen Hemminger
[not found] ` <20140504131750.45409335-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2014-05-05 10:53 ` Neil Horman
[not found] ` <20140505105309.GD16114-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-05-06 1:55 ` Stephen Hemminger
[not found] ` <20140505185531.4dbd94d4-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2014-05-06 11:04 ` Neil Horman
2014-05-06 12:52 ` Burakov, Anatoly
[not found] ` <C6ECDF3AB251BE4894318F4E45123697592AB70B-kPTMFJFq+rF9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-05-16 14:41 ` Thomas Monjalon
[not found] ` <20140502234251.707598579-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2014-05-16 14:42 ` [PATCH 0/5] Various patches to 1.6.0r2 Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5376065C.8080005@6wind.com \
--to=olivier.matz-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).