From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] drivers: update DPAA2 libs ABIVER and build
	reproducibility
Date: Tue, 10 Oct 2017 17:48:07 +0200
Message-ID: <5377044.W38hQe7MOC@xps>
References: <1507644941-21660-1-git-send-email-hemant.agrawal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, ferruh.yigit@intel.com
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 9C3301B316
 for <dev@dpdk.org>; Tue, 10 Oct 2017 17:48:09 +0200 (CEST)
In-Reply-To: <1507644941-21660-1-git-send-email-hemant.agrawal@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

10/10/2017 16:15, Hemant Agrawal:
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  drivers/bus/fslmc/Makefile        | 3 ++-
>  drivers/crypto/dpaa2_sec/Makefile | 3 ++-
>  drivers/event/dpaa2/Makefile      | 3 ++-
>  drivers/mempool/dpaa2/Makefile    | 3 ++-
>  drivers/net/dpaa2/Makefile        | 3 ++-
>  5 files changed, 10 insertions(+), 5 deletions(-)

Why are you changing LIBABIVER in all these libs?
Generally speaking, a driver should not upgrade its ABI version,
because it should have no interface.

The ABI version must be changed in the patch breaking the ABI.
If you do it later, it must be a fix with Fixes line.
This way we will have the reference to the code breaking the ABI.