From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] doc: announce kvargs API change
Date: Thu, 22 Nov 2018 15:02:28 +0100
Message-ID: <5377378.MItyz4mTKp@xps>
References: <20181121154545.14261-1-thomas@monjalon.net>
 <20181122103223.22837-1-thomas@monjalon.net>
 <20181122132212.brq3ifximbtu5c5d@platinum>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, anatoly.burakov@intel.com, ferruh.yigit@intel.com,
 arybchenko@solarflare.com, jerin.jacob@caviumnetworks.com,
 hemant.agrawal@nxp.com, gaetan.rivet@6wind.com
To: Olivier Matz <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 708981B437
 for <dev@dpdk.org>; Thu, 22 Nov 2018 15:02:37 +0100 (CET)
In-Reply-To: <20181122132212.brq3ifximbtu5c5d@platinum>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

22/11/2018 14:22, Olivier Matz:
> On Thu, Nov 22, 2018 at 11:32:23AM +0100, Thomas Monjalon wrote:
> > After processing a kvlist in rte_kvargs_process(),
> > it may be needed to loop again over kvlist in order to know
> > whether the key is matched or not.
> > In order to simplify implementation of kvargs checks,
> > a new pointer parameter may be used to get the match count.
> > 
> > The change of the function prototype would be as below:
> > 
> >  int
> >  rte_kvargs_process(const struct rte_kvargs *kvlist,
> >  		const char *key_match,
> > +		int *match_count,
> >  		arg_handler_t handler,
> >  		void *opaque_arg)
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Maybe "unsigned int" instead of "int".

Yes we will discuss such detail during review of the code patch.

> Apart from this,
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Thanks
I will consider the deprecation notice as approved when there will be 3 acks.