From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 0/4] New library: rte_distributor Date: Wed, 28 May 2014 00:32:42 +0200 Message-ID: <5389412.OPcvyX8cEM@xps13> References: <1400580057-30155-1-git-send-email-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Bruce Richardson Return-path: In-Reply-To: <1400580057-30155-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Bruce, As for rte_acl, I have some formatting comments. 2014-05-20 11:00, Bruce Richardson: > This adds a new library to the Intel DPDK whereby a set of packets can be > distributed one-at-a-time to a set of worker cores, with dynamic load > balancing being done between those workers. Flows are identified by a tag > within the mbuf (currently the RSS hash field, 32-bit value), which is used > to ensure that no two packets of the same flow are processed in parallel, > thereby preserving ordering. > > app/test/Makefile | 2 + > app/test/commands.c | 7 +- > app/test/test.h | 2 + > app/test/test_distributor.c | 582 +++++++++++++++++++++++++ > app/test/test_distributor_perf.c | 274 ++++++++++++ > config/defconfig_i686-default-linuxapp-gcc | 5 + > config/defconfig_i686-default-linuxapp-icc | 5 + > config/defconfig_x86_64-default-bsdapp-gcc | 6 + > config/defconfig_x86_64-default-linuxapp-gcc | 5 + > config/defconfig_x86_64-default-linuxapp-icc | 5 + > lib/Makefile | 1 + > lib/librte_distributor/Makefile | 50 +++ > lib/librte_distributor/rte_distributor.c | 417 ++++++++++++++++++ > lib/librte_distributor/rte_distributor.h | 173 ++++++++ > lib/librte_eal/common/include/rte_tailq_elem.h | 2 + > mk/rte.app.mk | 4 + > 16 files changed, 1539 insertions(+), 1 deletion(-) As you are introducing a new library, you need to update doxygen configuration and start page: doc/doxy-api.conf doc/doxy-api-index.md I've run checkpatch.pl from kernel.org on these distributor patches and it reports some code style issues. Could you have a look at it please? Thanks -- Thomas