From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Pablo de Lara
<pablox.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] string: fix potential seg fault on snprintf
Date: Fri, 27 Jun 2014 13:30:03 +0200 [thread overview]
Message-ID: <53AD55BB.8090807@6wind.com> (raw)
In-Reply-To: <1403867097-18848-1-git-send-email-pablox.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Hello Pablo,
On 06/27/2014 01:04 PM, Pablo de Lara wrote:
> From: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> Several functions did not check if destination buffer, used
> in snprintf was a non-NULL pointer.
Did you noticed any issue without this patch?
It seems that all the get_help() cmdline functions are never called
with a NULL destination buffer (see in cmdline_parse.c). I think it
is useless to add this test as there is no good reason to give a NULL
argument. It is like testing that the arguments of strcpy() are
non-NULL.
I would say the same for pci_get_uio_dev().
Regards,
Olivier
next prev parent reply other threads:[~2014-06-27 11:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 11:04 [PATCH] string: fix potential seg fault on snprintf Pablo de Lara
[not found] ` <1403867097-18848-1-git-send-email-pablox.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-06-27 11:30 ` Olivier MATZ [this message]
[not found] ` <53AD55BB.8090807-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-06-27 12:13 ` De Lara Guarch, Pablo
[not found] ` <E115CCD9D858EF4F90C690B0DCB4D8971A790399-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-27 12:34 ` Olivier MATZ
[not found] ` <53AD64D3.9000100-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-06-27 16:36 ` Richardson, Bruce
[not found] ` <59AF69C657FD0841A61C55336867B5B02CF0DEA1-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-30 7:41 ` Olivier MATZ
[not found] ` <53B114C5.2050608-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-06-30 16:48 ` Richardson, Bruce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AD55BB.8090807@6wind.com \
--to=olivier.matz-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=pablox.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).