From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] string: fix potential seg fault on snprintf
Date: Fri, 27 Jun 2014 14:34:27 +0200
Message-ID: <53AD64D3.9000100@6wind.com>
References: <1403867097-18848-1-git-send-email-pablox.de.lara.guarch@intel.com>
 <53AD55BB.8090807@6wind.com>
 <E115CCD9D858EF4F90C690B0DCB4D8971A790399@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
 "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8971A790399-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Pablo,

On 06/27/2014 02:13 PM, De Lara Guarch, Pablo wrote:
> With last Thomas' patch, cmdline unit test does not pass due to this problem (basically it tests this situation).
> After test passed, by fixing this issue in several functions, I looked for other places where this happened.

Indeed I missed the unit test, thanks.

I think that testing the NULL case is not required. To me, it is like
testing snprintf(NULL, ...)

Regards,
Olivier