From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Kuenzer Subject: Re: [PATCH] eal/linuxapp: Add parameter to specify master lcore id Date: Wed, 23 Jul 2014 14:05:17 +0200 Message-ID: <53CFA4FD.1060108@neclab.eu> References: <1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu> <10116389.N4VFaZKECM@xps13> <7F861DC0615E0C47A872E6F3C5FCDDBD011625D2@BPXM14GP.gisp.nec.co.jp> <3356411.EsFcTdggfg@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon , Hiroshi Shimamoto Return-path: In-Reply-To: <3356411.EsFcTdggfg@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 23.07.2014 11:04, Thomas Monjalon wrote: > 2014-07-23 08:53, Hiroshi Shimamoto: >> 2014-07-23 09:50, Thomas Monjalon: >>> 2014-07-22 23:40, Hiroshi Shimamoto: >>>> does anyone have interest in this functionality? >>>> >>>> I think this is important and useful. >>>> Since we should care about core assignment to get high performance >>>> and the master lcore thread is special in DPDK, we will want to >>>> assign the master to the target core. >>>> For example, with hyperthreading I'd like to make a pair of packet >>>> processing threads into one physical core and separate the master >>>> thread which does some management. >>> >>> Thank you for showing your interest. >>> Does it mean you carefully reviewed this patch? In this case, I'd appreciate >>> a note "Reviewed-by:". >> >> Not yet deeply, wait a bit, we're testing this patch in our application. >> Will report if it works fine. >> >> By the way, we should add the same code into the BSD code, right? > > Right. > I'd prefer to reduce the duplicated footprint and have more common code > between BSD and Linux. But waiting this enhancement, we have to maintain > the duplicated code for BSD. > Hi all, I can provide the same patch also for BSD. However, I do not have a machine to test it. Interested? Thanks, Simon