From mboxrd@z Thu Jan 1 00:00:00 1970 From: Qiaobing Xie Subject: Re: 1.7.0 release failed to compile on linux Date: Thu, 14 Aug 2014 18:27:40 -0500 Message-ID: <53ED45EC.8080906@gmail.com> References: <53ED2DBF.4070003@gmail.com> <4B613BEE-2D07-417D-ACA3-6C228FADB14E@windriver.com> <53ED3710.3090008@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: aws.ismail-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org Return-path: In-Reply-To: <53ED3710.3090008-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" OK, I made the following 3 changes and the v1.7.0 release tarball got=20 built cleanly on my older machine (Ubuntu 12.04/kernel=20 3.13.0-32-generic, Intel C2D E6550 without SSE4.x, gcc 4.6.3): 1) kcompat.h change version check from 3.14.0 -> 3.13.8, as Roger suggest= ed. 2) disable RTE_IXGBE_INC_VECTOR: -CONFIG_RTE_IXGBE_INC_VECTOR=3Dy +CONFIG_RTE_IXGBE_INC_VECTOR=3Dn 3) disable CONFIG_RTE_LIBRTE_ACL: -CONFIG_RTE_LIBRTE_ACL=3Dy +CONFIG_RTE_LIBRTE_ACL=3Dn I haven't tried to test run anything yet... What would be the=20 implication without LIBRTE_ACL and IXGBE_INC_VECTOR built? -Q On 8/14/14 5:24 PM, Aws Ismail wrote: > > > On 08/14/2014 05:55 PM, Wiles, Roger Keith wrote: >> For the SKB function change I had to change the ifdef in the=20 >> kcompat.h file around line 3848 (I think) to: >> >> /* #### Changed the next line to use (3,13,8) instead of (3,14,0)=20 >> KeithW */ >> #if ( LINUX_VERSION_CODE < KERNEL_VERSION(3,13,8) ) >> #if (!(RHEL_RELEASE_CODE && RHEL_RELEASE_CODE >=3D=20 >> RHEL_RELEASE_VERSION(7,0))) >> #ifdef NETIF_F_RXHASH >> #define PKT_HASH_TYPE_L3 0 >> static inline void >> skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type= ) >> { >> skb->rxhash =3D hash; >> } >> #endif /* NETIF_F_RXHASH */ >> #endif /* < RHEL7 */ >> #endif /* < 3.14.0 */ >> >> >> Keith Wiles, Principal Technologist with CTO office, Wind River=20 >> mobile 972-213-5533 >> >> On Aug 14, 2014, at 4:44 PM, Qiaobing Xie=20 >> > wrote: >> >> Hi, >> >> I got the following error when I tried to compile 1.7.0 release=20 >> tarball on a Linux box (Ubuntu 12.04/kernel=3D3.13.0-32-generic,=20 >> gcc=3D4.6.3): >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> In file included from=20 >> /home/qxie/dpdk-1.7.0/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_os= dep.h:41:0, >> from=20 >> /home/qxie/dpdk-1.7.0/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw= .h:31, >> from=20 >> /home/qxie/dpdk-1.7.0/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_ap= i.h:31, >> from=20 >> /home/qxie/dpdk-1.7.0/build/build/lib/librte_eal/linuxapp/kni/e1000_82= 575.c:38: >> /home/qxie/dpdk-1.7.0/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.= h:3853:1:=20 >> error: conflicting types for =91skb_set_hash=92 >> /usr/src/linux-headers-3.13.0-32-generic/include/linux/skbuff.h:740:1:= note:=20 >> previous definition of =91skb_set_hash=92 was here > Last time I checked, I overcame this error by not using the tarball=20 > but by simply cloning the dpdk git repo and checking out the=20 > v1.7.0-rc4 tag. For example: > > git clone git://dpdk.org/dpdk > git checkout v1.7.0-rc4 > git checkout -b dpdk1.7.0-rc4 <---- the branch name is just an=20 > example, you could decide on any other name as you see fit. > > My machine info: > > 3.11.0-20 kernel, ubuntu 12.04, gcc 4.6.3 > > From the v1.7.0-rc4 tag, viewing=20 > lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3848, you could see: > > > #if ( LINUX_VERSION_CODE < KERNEL_VERSION(3,14,0) ) > #if (!(RHEL_RELEASE_CODE && RHEL_RELEASE_CODE >=3D=20 > RHEL_RELEASE_VERSION(7,0))) > #ifdef NETIF_F_RXHASH > #define PKT_HASH_TYPE_L3 0 > static inline void > skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type) > { > skb->rxhash =3D hash; > } > #endif /* NETIF_F_RXHASH */ > #endif /* < RHEL7 */ > #endif /* < 3.14.0 */ > > >> make[8]: ***=20 >> [/home/qxie/dpdk-1.7.0/build/build/lib/librte_eal/linuxapp/kni/e1000_8= 2575.o]=20 >> Error 1 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> Apparently the version check around 'skb_set_hash' in kcompat.h=20 >> failed for some reason. To work around it, I temporarily commented=20 >> out that 'skb_set_hash' definition code and rte_kni complied fine.=20 >> But it failed again in librte_pmd_ixgbe: >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> In file included from=20 >> /home/qxie/dpdk-1.7.0/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:41:0: >> /usr/lib/gcc/x86_64-linux-gnu/4.6/include/nmmintrin.h:31:3: error:=20 >> #error "SSE4.2 instruction set not enabled" >> /home/qxie/dpdk-1.7.0/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c: In=20 >> function =91ixgbe_recv_pkts_vec=92: >> /home/qxie/dpdk-1.7.0/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:297:3:=20 >> error: implicit declaration of function =91_mm_shuffle_epi8=92=20 >> [-Werror=3Dimplicit-function-declaration] >> /home/qxie/dpdk-1.7.0/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:297:3:=20 >> error: nested extern declaration of =91_mm_shuffle_epi8=92=20 >> [-Werror=3Dnested-externs] >> /home/qxie/dpdk-1.7.0/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:297:11:=20 >> error: incompatible types when assigning to type =91__m128i=92 from ty= pe=20 >> =91int=92 >> /home/qxie/dpdk-1.7.0/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:298:11:=20 >> error: incompatible types when assigning to type =91__m128i=92 from ty= pe=20 >> =91int=92 >> /home/qxie/dpdk-1.7.0/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:313:11:=20 >> error: incompatible types when assigning to type =91__m128i=92 from ty= pe=20 >> =91int=92 >> /home/qxie/dpdk-1.7.0/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:314:11:=20 >> error: incompatible types when assigning to type =91__m128i=92 from ty= pe=20 >> =91int=92 >> /home/qxie/dpdk-1.7.0/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:341:3:=20 >> error: implicit declaration of function =91_mm_popcnt_u64=92=20 >> [-Werror=3Dimplicit-function-declaration] >> /home/qxie/dpdk-1.7.0/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:341:3:=20 >> error: nested extern declaration of =91_mm_popcnt_u64=92=20 >> [-Werror=3Dnested-externs] >> cc1: all warnings being treated as errors >> make[3]: *** [ixgbe_rxtx_vec.o] Error 1 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> My CPU is the older Intel C2D E6550 which does not have sse4.2/sse4.1=20 >> support. Is there a way to work around this? >> >> -Q >> >> >> >> >> >> >