From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v2 01/14] eal: expose rte_eal_using_phys_addrs
Date: Mon, 18 Sep 2017 16:17:08 +0530
Message-ID: <53c6676d-14fe-7037-29db-ae3265257a82@nxp.com>
References: <cover.1503651392.git.gaetan.rivet@6wind.com>
 <cover.1505726803.git.gaetan.rivet@6wind.com>
 <d50965340fd71c6556da620243b70d6d6263282d.1505726803.git.gaetan.rivet@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
 (mail-bl2nam02on0046.outbound.protection.outlook.com [104.47.38.46])
 by dpdk.org (Postfix) with ESMTP id A0637325A
 for <dev@dpdk.org>; Mon, 18 Sep 2017 12:36:14 +0200 (CEST)
In-Reply-To: <d50965340fd71c6556da620243b70d6d6263282d.1505726803.git.gaetan.rivet@6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello Gaetan,

On Monday 18 September 2017 03:01 PM, Gaetan Rivet wrote:
> This function was previously private to the EAL layer.
> Other subsystems requires it, such as the PCI bus.
> 
> In order not to force other components to include stdbool, which is
> incompatible with several NIC drivers, the return type has
> been changed from bool to int.
> 
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---

[...]

> diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c
> index 5279128..af8719b 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_memory.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
> @@ -1542,7 +1542,7 @@ rte_eal_hugepage_attach(void)
>   	return -1;
>   }
>   
> -bool
> +int
>   rte_eal_using_phys_addrs(void)
>   {
>   	return phys_addrs_available;
> diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> index 8c08b8d..f866b70 100644
> --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> @@ -205,6 +205,7 @@ DPDK_17.08 {

This symbol should be added to 17.11, isn't it?

>   	rte_bus_find;
>   	rte_bus_find_by_device;
>   	rte_bus_find_by_name;
> +	rte_eal_using_phys_addrs;
>   	rte_log_get_level;
>   
>   } DPDK_17.05;
> 
-
Shreyansh