From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hemant Agrawal Subject: Re: [PATCH v4 2/4] change root makefile license to SPDX tag Date: Tue, 19 Dec 2017 10:59:26 +0530 Message-ID: <53f0f426-2d0b-1cbb-2161-0d03ba0b76f9@nxp.com> References: <1512718913-11462-1-git-send-email-hemant.agrawal@nxp.com> <1513600744-13749-2-git-send-email-hemant.agrawal@nxp.com> <20171218155217.GA10816@bricha3-MOBL3.ger.corp.intel.com> <4147827.fBL4TnQB7r@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: , To: Thomas Monjalon , Bruce Richardson Return-path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0075.outbound.protection.outlook.com [104.47.36.75]) by dpdk.org (Postfix) with ESMTP id B2E2FE5D for ; Tue, 19 Dec 2017 06:29:31 +0100 (CET) In-Reply-To: <4147827.fBL4TnQB7r@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/18/2017 10:00 PM, Thomas Monjalon wrote: > 18/12/2017 16:52, Bruce Richardson: >> On Mon, Dec 18, 2017 at 06:09:02PM +0530, Hemant Agrawal wrote: >>> --- a/GNUmakefile >>> +++ b/GNUmakefile >>> @@ -1,33 +1,6 @@ >>> -# BSD LICENSE >>> +# SPDX-License-Identifier: BSD-3-Clause >>> # >>> # Copyright(c) 2010-2015 Intel Corporation. All rights reserved. >> >> Actually, minor comment, can we remove the blank line between the SPDX >> identifier and the copyright? Given that in the majority of cases, we >> will only have one line each, having a space between them is a) probably >> unnecessary, and b) looks weird IMHO. >> >> I'm currently working on a patchset to update the meson.build files, and >> I think having: >> >> # SPDX-License-Identifier: BSD-3-Clause >> # Copyright(c) 2017 Intel Corporation >> >> looks better as a header than two one-line paragraphs. > > +1, I agree with Bruce > I will fix it. However, I will suggest to not enforced it as a policy. Let the copyright owners decide, how they want to place the copyright.