From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] librte: Link status interrupt race condition,
	IGB E1000
Date: Tue, 27 Oct 2015 18:45:20 +0100
Message-ID: <5406727.UN0rhZ0d4I@xps13>
References: <33526A3108217C45B7DAFFA5277E4B67485277B3@mbx024-e1-nj-2.exch024.domain.local>
 <6060754.bW1Xky3pZ1@xps13>
 <6A0DE07E22DDAD4C9103DF62FEBC0909020A2AE8@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Tim Shearer <tim.shearer@overturenetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com
 [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id 672C88D8D
 for <dev@dpdk.org>; Tue, 27 Oct 2015 18:46:30 +0100 (CET)
Received: by wicfx6 with SMTP id fx6so170555436wic.1
 for <dev@dpdk.org>; Tue, 27 Oct 2015 10:46:30 -0700 (PDT)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909020A2AE8@shsmsx102.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-10-26 05:25, Lu, Wenzhuo:
> I think you're right. To my opinion, this if is added to avoid the race condition. So, it should be " dev->data->dev_conf.intr_conf.lsc == 0". It means if the interrupts are not enabled, we'd update the link when starting, if not we can leave it the interrupt handler.
> Seems it's not an igb specific but common issue. 

Tim, please could you send an appropriate patch?
The procedure is described in http://dpdk.org/dev#send

Could you also check if other PMDs have the same bug?
Thanks