Re: [PATCH v3 4/6] mbuf: remove the rte_pktmbuf structure

[Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]

On 09/04/2014 03:25 PM, Bruce Richardson wrote:
> From: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> 
> The rte_pktmbuf structure was initially included in the rte_mbuf
> structure. This was needed when there was 2 types of mbuf (ctrl and
> packet). As the control mbuf has been removed, we can merge the
> rte_pktmbuf into the rte_mbuf structure.
> 
> Advantages of doing this:
>   - the access to mbuf fields is easier (ex: m->data instead of m->pkt.data)
>   - make the structure more consistent: for instance, there was no reason
>     to have the ol_flags field in rte_mbuf
>   - it will allow a deeper reorganization of the rte_mbuf structure in the
>     next commits, allowing to gain several bytes in it
> 
> Signed-off-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> 
> Updated to work with latest code, and to include new example apps.
> 
> Changes in V2:
> * Further updates to apply to latest HEAD on master
> 
> Changes in V3:
> * Updated to compile cleanly on 1.7.1
> 
> Signed-off-by: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

In app/test/packet_burst_generator.c, there is one remaining reference
to "pkt." in a comment:

  #define RTE_MAX_SEGS_PER_PKT 255 /**< pkt.nb_segs is a 8-bit unsigned
char. */


Acked-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>